All notes

Quality

7 min read

Reviewing code you didn't type

Agents write most of my code now. Reading it well is the part of the job that grew.

When I wrote everything by hand, review was something I did for other people. Now nearly every line in my projects started in a model, and reading code has become most of my job. It needed a method.

Read the tests first

The tests say what the code claims to do. If they are thin, the code has not earned a review yet. I send it back with the cases I want covered before I read anything else.

Then read for what is missing

  • The error nobody handled

  • The query without a limit

  • The permission check that only the interface does

  • The copy that says what happened, but not what to do

Agents are good at the happy path. Review is mostly the search for the unhappy ones.

If I cannot explain a line to the client, it does not ship.

Keep a list of what keeps coming back

Every mistake I catch twice becomes a line in the project's rules file, which the agents read before they start. The list grows, and the same review gets shorter every month.

When I wrote everything by hand, review was something I did for other people. Now nearly every line in my projects started in a model, and reading code has become most of my job. It needed a method.

Read the tests first

The tests say what the code claims to do. If they are thin, the code has not earned a review yet. I send it back with the cases I want covered before I read anything else.

Then read for what is missing

  • The error nobody handled

  • The query without a limit

  • The permission check that only the interface does

  • The copy that says what happened, but not what to do

Agents are good at the happy path. Review is mostly the search for the unhappy ones.

If I cannot explain a line to the client, it does not ship.

Keep a list of what keeps coming back

Every mistake I catch twice becomes a line in the project's rules file, which the agents read before they start. The list grows, and the same review gets shorter every month.

When I wrote everything by hand, review was something I did for other people. Now nearly every line in my projects started in a model, and reading code has become most of my job. It needed a method.

Read the tests first

The tests say what the code claims to do. If they are thin, the code has not earned a review yet. I send it back with the cases I want covered before I read anything else.

Then read for what is missing

  • The error nobody handled

  • The query without a limit

  • The permission check that only the interface does

  • The copy that says what happened, but not what to do

Agents are good at the happy path. Review is mostly the search for the unhappy ones.

If I cannot explain a line to the client, it does not ship.

Keep a list of what keeps coming back

Every mistake I catch twice becomes a line in the project's rules file, which the agents read before they start. The list grows, and the same review gets shorter every month.

Written by Kai Moreno

Independent product engineer, Lisbon

Ready to ship?

Let’s build together.

From the first version to production, at a startup’s speed and with a senior engineer’s care. Tell me about your product.

2 builds open for December

Ready to ship?

Let’s build together.

From the first version to production, at a startup’s speed and with a senior engineer’s care. Tell me about your product.

2 builds open for December

Ready to ship?

Let’s build together.

From the first version to production, at a startup’s speed and with a senior engineer’s care. Tell me about your product.

2 builds open for December

Create a free website with Framer, the website builder loved by startups, designers and agencies.